[tests-only][full-ci] refactoring user creation Given steps from provisioning into GraphContext
#7019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S-Panta
force-pushed
the
refactoring-user-creation-testcode-to-graphapi
branch
from
9fcd2de
to
3599c15
Compare
S-Panta
requested review from
saw-jan,
SwikritiT,
SagarGi,
grgprarup,
amrita-shrestha and
PrajwolAmatya
S-Panta
force-pushed
the
refactoring-user-creation-testcode-to-graphapi
branch
5 times, most recently
from
934c890
to
e312930
Compare
S-Panta
changed the title
Given user creation steps from provisioning into GraphContext
S-Panta
changed the title
Given user creation steps from provisioning into GraphContextgiven steps from provisioning into GraphContext
S-Panta
changed the title
given steps from provisioning into GraphContextGiven steps from provisioning into GraphContext
SwikritiT
reviewed
Aug 15, 2023
S-Panta
force-pushed
the
refactoring-user-creation-testcode-to-graphapi
branch
4 times, most recently
from
af51a46
to
ce715e4
Compare
S-Panta
commented
Aug 18, 2023
S-Panta
commented
Aug 18, 2023
S-Panta
commented
Aug 18, 2023
S-Panta
force-pushed
the
refactoring-user-creation-testcode-to-graphapi
branch
4 times, most recently
from
075c846
to
ac8edad
Compare
…ected failure files
S-Panta
force-pushed
the
refactoring-user-creation-testcode-to-graphapi
branch
from
695f715
to
8aadb65
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
saw-jan
approved these changes
Sep 5, 2023
delete-merged-branch
bot
deleted the
refactoring-user-creation-testcode-to-graphapi
branch
ownclouders
pushed a commit
that referenced
this pull request
Sep 6, 2023
…ovisioning into GraphContext (#7019) * refactored the user creation given statement from provisioning to graph api added getUser steps that covers the steps for user with user light role * added userlight step tests to check drive information and updated expected failure files * added usercreation initiation code * deleted seperate tests for user light role * remove unnecesary changes * add user not initialize step * corrected the testcode * moved the steps from graph to provisioning file * fix creating single ldap user * fix: user check method * initialize user via graph * addressing reviews --------- Co-authored-by: Saw-jan <saw.jan.grg3e@gmail.com>
2 tasks
|
@S-Panta can you please backport this PR to stable-4.0 as well |
S-Panta
added a commit
that referenced
this pull request
Sep 11, 2023
…ovisioning into GraphContext (#7019) * refactored the user creation given statement from provisioning to graph api added getUser steps that covers the steps for user with user light role * added userlight step tests to check drive information and updated expected failure files * added usercreation initiation code * deleted seperate tests for user light role * remove unnecesary changes * add user not initialize step * corrected the testcode * moved the steps from graph to provisioning file * fix creating single ldap user * fix: user check method * initialize user via graph * addressing reviews --------- Co-authored-by: Saw-jan <saw.jan.grg3e@gmail.com>
saw-jan
added a commit
that referenced
this pull request
Sep 11, 2023
…ovisioning into GraphContext (#7019) (#7259) * refactored the user creation given statement from provisioning to graph api added getUser steps that covers the steps for user with user light role * added userlight step tests to check drive information and updated expected failure files * added usercreation initiation code * deleted seperate tests for user light role * remove unnecesary changes * add user not initialize step * corrected the testcode * moved the steps from graph to provisioning file * fix creating single ldap user * fix: user check method * initialize user via graph * addressing reviews --------- Co-authored-by: Saw-jan <saw.jan.grg3e@gmail.com>
ownclouders
pushed a commit
that referenced
this pull request
Sep 11, 2023
…ovisioning into GraphContext (#7019) (#7259) * refactored the user creation given statement from provisioning to graph api added getUser steps that covers the steps for user with user light role * added userlight step tests to check drive information and updated expected failure files * added usercreation initiation code * deleted seperate tests for user light role * remove unnecesary changes * add user not initialize step * corrected the testcode * moved the steps from graph to provisioning file * fix creating single ldap user * fix: user check method * initialize user via graph * addressing reviews --------- Co-authored-by: Saw-jan <saw.jan.grg3e@gmail.com>
ownclouders
pushed a commit
that referenced
this pull request
Sep 12, 2023
…ovisioning into GraphContext (#7019) (#7259) * refactored the user creation given statement from provisioning to graph api added getUser steps that covers the steps for user with user light role * added userlight step tests to check drive information and updated expected failure files * added usercreation initiation code * deleted seperate tests for user light role * remove unnecesary changes * add user not initialize step * corrected the testcode * moved the steps from graph to provisioning file * fix creating single ldap user * fix: user check method * initialize user via graph * addressing reviews --------- Co-authored-by: Saw-jan <saw.jan.grg3e@gmail.com>
ownclouders
pushed a commit
that referenced
this pull request
Sep 12, 2023
…ovisioning into GraphContext (#7019) (#7259) * refactored the user creation given statement from provisioning to graph api added getUser steps that covers the steps for user with user light role * added userlight step tests to check drive information and updated expected failure files * added usercreation initiation code * deleted seperate tests for user light role * remove unnecesary changes * add user not initialize step * corrected the testcode * moved the steps from graph to provisioning file * fix creating single ldap user * fix: user check method * initialize user via graph * addressing reviews --------- Co-authored-by: Saw-jan <saw.jan.grg3e@gmail.com>
ownclouders
pushed a commit
that referenced
this pull request
Sep 12, 2023
…ovisioning into GraphContext (#7019) (#7259) * refactored the user creation given statement from provisioning to graph api added getUser steps that covers the steps for user with user light role * added userlight step tests to check drive information and updated expected failure files * added usercreation initiation code * deleted seperate tests for user light role * remove unnecesary changes * add user not initialize step * corrected the testcode * moved the steps from graph to provisioning file * fix creating single ldap user * fix: user check method * initialize user via graph * addressing reviews --------- Co-authored-by: Saw-jan <saw.jan.grg3e@gmail.com>
ownclouders
pushed a commit
that referenced
this pull request
Sep 13, 2023
…ovisioning into GraphContext (#7019) (#7259) * refactored the user creation given statement from provisioning to graph api added getUser steps that covers the steps for user with user light role * added userlight step tests to check drive information and updated expected failure files * added usercreation initiation code * deleted seperate tests for user light role * remove unnecesary changes * add user not initialize step * corrected the testcode * moved the steps from graph to provisioning file * fix creating single ldap user * fix: user check method * initialize user via graph * addressing reviews --------- Co-authored-by: Saw-jan <saw.jan.grg3e@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the steps in the Provisioning API and moves those steps relating to user creation to the GraphContext file. Only the test code which are in use in the current feature file are moved while the unused code relating to user creation aren't cleaned in this PR. Only the test code of
Givensteps are refactored in the process.Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: